TYP: fix typing error in hookspecs, refactor NebariStage
Reference Issues or PRs
xref #1800 ##1894
What does this implement/fix?
Put a x in the boxes that apply
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds a feature)
- [ ] Breaking change (fix or feature that would cause existing features not to work as expected)
- [ ] Documentation Update
- [ ] Code style update (formatting, renaming)
- [x] Refactoring (no functional changes, no API changes)
- [ ] Build related changes
- [ ] Other (please describe):
Testing
- [x] Did you test the pull request locally?
- [ ] Did you add new tests?
Any other comments?
@costrouc could you have a look at this PR?
@viniciusdc will check
This has some big refactorings in the Nebari Stage which needs to be retested now that we changed a bit the behavior for the default schema dumps -- I will follow up on this, next week
@viniciusdc should we close this one or is there still value here?
Hi @dcmcand, There is a lot of value here. This is good work that we will need to encompass sooner or later (related to that schema refactoring I was talking about recently). I was waiting on this due to the exposing default config values Adam was working on.
My opinion on this would be to close, and we will incorporate and cite those changes in a follow up PR