nebari icon indicating copy to clipboard operation
nebari copied to clipboard

TYP: fix typing error in hookspecs, refactor NebariStage

Open fangchenli opened this issue 2 years ago • 5 comments

Reference Issues or PRs

xref #1800 ##1894

What does this implement/fix?

Put a x in the boxes that apply

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds a feature)
  • [ ] Breaking change (fix or feature that would cause existing features not to work as expected)
  • [ ] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [x] Refactoring (no functional changes, no API changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

  • [x] Did you test the pull request locally?
  • [ ] Did you add new tests?

Any other comments?

fangchenli avatar Sep 03 '23 06:09 fangchenli

@costrouc could you have a look at this PR?

iameskild avatar Nov 08 '23 08:11 iameskild

@viniciusdc will check

dcmcand avatar Mar 18 '24 15:03 dcmcand

This has some big refactorings in the Nebari Stage which needs to be retested now that we changed a bit the behavior for the default schema dumps -- I will follow up on this, next week

viniciusdc avatar May 23 '24 14:05 viniciusdc

@viniciusdc should we close this one or is there still value here?

dcmcand avatar Jun 18 '24 22:06 dcmcand

Hi @dcmcand, There is a lot of value here. This is good work that we will need to encompass sooner or later (related to that schema refactoring I was talking about recently). I was waiting on this due to the exposing default config values Adam was working on.

My opinion on this would be to close, and we will incorporate and cite those changes in a follow up PR

viniciusdc avatar Jun 29 '24 00:06 viniciusdc