nebari icon indicating copy to clipboard operation
nebari copied to clipboard

Switch to CalVer

Open iameskild opened this issue 3 years ago • 3 comments

Fixes | Closes | Resolves #1454

Please remove anything marked as optional that you don't need to fill in. Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

  • Update CI to run on release/** branches
  • Switch project from SemVer to CalVer

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds a feature)
  • [ ] Breaking change (fix or feature that would cause existing features to not work as expected)
  • [ ] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Build related changes
  • [x] Other (please describe):

Testing

Requires testing

  • [ ] Yes
  • [ ] No

In case you checked yes, did you write tests?

  • [ ] Yes
  • [ ] No

Documentation

Does your contribution include breaking changes or deprecations? If so have you updated the documentation?

  • [ ] Yes, docstrings
  • [ ] Yes, main documentation
  • [ ] Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

iameskild avatar Oct 18 '22 22:10 iameskild

@trallard I know we have the 2022.10.1 branch but I wanted to know how you feel about using a branch name of release/YYYY.MM.XX? I think this latter branch name communicates the intention of this branch. What do you think?

iameskild avatar Oct 18 '22 22:10 iameskild

We might also need to create a dummy tag (like 2022.10.0) for setuptools_scm to pick up the new convention.

iameskild avatar Oct 18 '22 22:10 iameskild

@trallard I would like to cut a 2022.10.1.dev0 release (+tag) tomorrow to test how this switch to calver and to test the pypi download, how does that sound to you?

iameskild avatar Oct 20 '22 04:10 iameskild

sounds good - I need to make a release of https://github.com/nebari-dev/nebari-jupyterhub-theme/ so that we can also grab the screenshots with the updated theme

trallard avatar Oct 21 '22 14:10 trallard

@trallard 2022.10.1.dev0 is now available on PyPI.

And pip install qhub==2022.10.1.dev0 seems to work as expected 🤗

iameskild avatar Oct 21 '22 14:10 iameskild