nebari
nebari copied to clipboard
[ENH] Switch default and filesystem name envs
Changes introduced in this PR:
- Update
filesystem
anddefault
environment names tonebari-git
andglobal
respectfully
related to #1349
Types of changes
What types of changes does your PR introduce?
Put an x
in the boxes that apply
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds a feature)
- [x] Breaking change (fix or feature that would cause existing features to not work as expected)
- [ ] Documentation Update
- [ ] Code style update (formatting, renaming)
- [x] Refactoring (no functional changes, no API changes)
- [ ] Build related changes
- [ ] Other (please describe):
Testing
Requires testing
- [x] Yes
- [ ] No
In case you checked yes, did you write tests?
- [ ] Yes
- [x] No
Documentation
Does your contribution include breaking changes or deprecations? If so have you updated the documentation?
- [ ] Yes, docstrings
- [ ] Yes, main documentation
- [ ] Yes, deprecation notices
Further comments (optional)
This will require a full deployment of Qhub to validate all services run as excepted.
I think I am missing something
yeah... not sure why this is showing up here:
I am out of ideas now... @costrouc may you have a look if I am missing something? Even with a fresh install, the old namespaces were created.
I've also tried using
c.CondaStore.default_namespace = "global"
c.CondaStore.filesystem_namespace = "nebari-git"
@costrouc this is waiting for your input ☝🏽
Blocked by #conda
@viniciusdc I opened this PR in nebari-docker-images repo given that we recently decoupled the images. I will try to test this as well given the concerns I raised above 👍
@viniciusdc I opened this PR in nebari-docker-images repo given that we recently decoupled the images. I will try to test this as well, given the concerns I raised above +1
Thanks, @iameskild. Also, I forgot to answer your points above, apologies, I believe the old environments will still be in there, but some of the services might not show them. The users will need to recreate the environments in the new namespaces as I don't think conda-store will treat those changes as a proper "renaming."
Ok... so this will need to be updated:
-
default
->global
->nebari-system
@costrouc Is there a way to hide this environment from the user?
@viniciusdc yes we just drop permissions for users with this given namespace and they will no longer see it.
Thanks @HarshCasper I will have a look and test this as well!!! :smile:
@HarshCasper based on what we discussed today, we will need to make the nebari-git
a customizable name in the config (e.g default-conda-env-name
) -- we can use the input variables and the ztjb custom config to pass through the values.
Regarding the name for global,
we need to make sure this is just used in the installation part of jupyterhub/jupyterlab -- I am inclined to say that's the only case. Still, we can verify by checking wich env is used in the user pod terminal...
To hide an environment, we can change the permission part of global to admin only -- this should hide for the others...
TODO: add troubleshooting section for folks upgrading to 0.4.5
and reference section on envs