nebari icon indicating copy to clipboard operation
nebari copied to clipboard

[ENH] Switch default and filesystem name envs

Open viniciusdc opened this issue 2 years ago • 7 comments

Changes introduced in this PR:

  • Update filesystem and default environment names to nebari-git and global respectfully

related to #1349

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds a feature)
  • [x] Breaking change (fix or feature that would cause existing features to not work as expected)
  • [ ] Documentation Update
  • [ ] Code style update (formatting, renaming)
  • [x] Refactoring (no functional changes, no API changes)
  • [ ] Build related changes
  • [ ] Other (please describe):

Testing

Requires testing

  • [x] Yes
  • [ ] No

In case you checked yes, did you write tests?

  • [ ] Yes
  • [x] No

Documentation

Does your contribution include breaking changes or deprecations? If so have you updated the documentation?

  • [ ] Yes, docstrings
  • [ ] Yes, main documentation
  • [ ] Yes, deprecation notices

Further comments (optional)

This will require a full deployment of Qhub to validate all services run as excepted.

viniciusdc avatar Jul 01 '22 15:07 viniciusdc

I think I am missing something image yeah... not sure why this is showing up here: image

viniciusdc avatar Jul 01 '22 20:07 viniciusdc

I am out of ideas now... @costrouc may you have a look if I am missing something? Even with a fresh install, the old namespaces were created.

I've also tried using

c.CondaStore.default_namespace = "global"
c.CondaStore.filesystem_namespace = "nebari-git"

viniciusdc avatar Jul 02 '22 17:07 viniciusdc

@costrouc this is waiting for your input ☝🏽

trallard avatar Jul 05 '22 13:07 trallard

Blocked by #conda

trallard avatar Aug 09 '22 14:08 trallard

@viniciusdc I opened this PR in nebari-docker-images repo given that we recently decoupled the images. I will try to test this as well given the concerns I raised above 👍

iameskild avatar Aug 16 '22 01:08 iameskild

@viniciusdc I opened this PR in nebari-docker-images repo given that we recently decoupled the images. I will try to test this as well, given the concerns I raised above +1

Thanks, @iameskild. Also, I forgot to answer your points above, apologies, I believe the old environments will still be in there, but some of the services might not show them. The users will need to recreate the environments in the new namespaces as I don't think conda-store will treat those changes as a proper "renaming."

viniciusdc avatar Aug 16 '22 13:08 viniciusdc

Ok... so this will need to be updated:

  • default -> global -> nebari-system

@costrouc Is there a way to hide this environment from the user?

viniciusdc avatar Aug 16 '22 15:08 viniciusdc

@viniciusdc yes we just drop permissions for users with this given namespace and they will no longer see it.

costrouc avatar Sep 22 '22 03:09 costrouc

Thanks @HarshCasper I will have a look and test this as well!!! :smile:

viniciusdc avatar Sep 27 '22 14:09 viniciusdc

@HarshCasper based on what we discussed today, we will need to make the nebari-git a customizable name in the config (e.g default-conda-env-name) -- we can use the input variables and the ztjb custom config to pass through the values.

Regarding the name for global, we need to make sure this is just used in the installation part of jupyterhub/jupyterlab -- I am inclined to say that's the only case. Still, we can verify by checking wich env is used in the user pod terminal...

To hide an environment, we can change the permission part of global to admin only -- this should hide for the others...

viniciusdc avatar Sep 27 '22 14:09 viniciusdc

TODO: add troubleshooting section for folks upgrading to 0.4.5 and reference section on envs

trallard avatar Oct 11 '22 14:10 trallard