laconia icon indicating copy to clipboard operation
laconia copied to clipboard

Run acceptance-test in build pipeline

Open ceilfors opened this issue 5 years ago • 1 comments

Story As a maintainer, I would like the acceptance test to be running in our build pipeline, So that I don't have to run it manually every time I want to make a new release or merging a new pull request

Acceptance Criteria

  • npm run test:acceptance to be running on every pull requests
  • Setup must be secure that AWS credentials can't be stolen in fork

Additional context

Laconia's acceptance test is currently running in the cloud. This means two things:

  • Contributors might not be interested to run it, because it will involve cost and cloud setup. (Although, seems like all the services we use are falling under free tier?)
  • We need AWS credentials to run the acceptance test. There is a security risk when we're setting the credentials on fork, i.e. attacker can create a new pull request that console.log our environment variables.

ceilfors avatar Jun 17 '19 05:06 ceilfors

Maybe we could create suborganizations the will run tests.

And would be cool if we can create it and delete it for every build.

hugosenari avatar Jan 21 '20 23:01 hugosenari