graphql-hooks icon indicating copy to clipboard operation
graphql-hooks copied to clipboard

chore(deps): Bump fastify from 3.29.0 to 4.2.0

Open dependabot[bot] opened this issue 2 years ago • 4 comments

Bumps fastify from 3.29.0 to 4.2.0.

Release notes

Sourced from fastify's releases.

v4.2.0

What's Changed

New Contributors

Full Changelog: https://github.com/fastify/fastify/compare/v4.1.0...v4.2.0

v4.1.0

What's Changed

New Contributors

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Jun 28 '22 21:06 dependabot[bot]

current state of this...

I updated a lot of direct dependencies and fixed function signatures.

but running:

npm run start:mercurius --prefix ./examples/persisted-queries/server

is raising this error:

(node:93672) UnhandledPromiseRejectionWarning: FastifyError: fastify-plugin: fastify-cors - expected '3.x' fastify version, '4.2.0' is installed

none of these are direct dependencies (they're only listed on -locks as required indirect dependencies):

Screen Shot 2022-07-11 at 10 03 52

regarding fastify-cors, it was replaced by @fastify/cors and it's using v8 everywhere here, already supports fastify v4

but regarding fastify-plugin, its v3 don't support fastify v4 and is listed as a requirement for:

  • @fastify/cors - merged update, but no release version
  • @fastify/static - not even PR yet
  • @fastify/websocket - merged update, but no release version
  • mercurius - failing PR

considering that fastify-plugin v4 is already using fastify v4, then I'm just working to fix these last indirect dependencies above.

Mazuh avatar Jul 11 '22 13:07 Mazuh

@mcollina, can you give me a suggestion of course of action here? What I'm doing is update these nested dependencies and wait for their release but it seems a lot unnecessary work. I'm not sure if skip-override can help here (not very sure how to use it, to be more specific).

Mazuh avatar Jul 12 '22 14:07 Mazuh

A newer version of fastify exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot[bot] avatar Jul 12 '22 21:07 dependabot[bot]

@Mazuh any news on this?

simoneb avatar Jul 15 '22 09:07 simoneb