wallet-selector icon indicating copy to clipboard operation
wallet-selector copied to clipboard

Published 20 hours ago • verified publisher icon near

Narwallets

Open Calcifer1001 opened this issue 2 years ago • 6 comments

Description

Please include a summary of the wallet and how users can install it. Be sure to take a look at our guide on Custom Wallets to understand core concepts when integrating with Wallet Selector.

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

Calcifer1001 avatar Oct 13 '22 13:10 Calcifer1001

Hey, @Calcifer1001 thank you for submitting this PR.

Can you please change the base branch from main to dev branch?

Decided to close the old PR in favor of this one but please address the comments left there: #475

kujtimprenkuSQA avatar Oct 17 '22 08:10 kujtimprenkuSQA

My bad. Changed base to dev.

Calcifer1001 avatar Oct 17 '22 15:10 Calcifer1001

Narwallets v4 has already been published on chrome's store and a push has been made to properly set the download url

Calcifer1001 avatar Oct 17 '22 15:10 Calcifer1001

Hey @Calcifer1001 as a reminder, the statement of compliance needs to be shown either on your GitHub repo or the website. You can check it here. Thanks!

AmmarHumackicSQA avatar Oct 20 '22 14:10 AmmarHumackicSQA

Hello @AmmarHumackicSQA. May I ask you of an example of the statement of compliance, on how you expect us to have it on our end? Thank you

Calcifer1001 avatar Oct 21 '22 15:10 Calcifer1001

Hello @AmmarHumackicSQA. May I ask you of an example of the statement of compliance, on how you expect us to have it on our end? Thank you

Hey @Calcifer1001 you can follow what is described in the CONTRIBUTING.md:

"Wallets shall checkbox a statement of compliance to be maintained on the wallet’s GitHub account or Website. The statement may qualitatively discuss the security program and include additional elements, or simply state that it is compliant with the program outlined below. When asserting that open items will be in place within some time period of being listed, target dates shall be included and clearly defined..."

AmmarHumackicSQA avatar Oct 24 '22 08:10 AmmarHumackicSQA

Hello @AmmarHumackicSQA. May I ask you of an example of the statement of compliance, on how you expect us to have it on our end? Thank you

Hey @Calcifer1001 you can follow what is described in the CONTRIBUTING.md:

"Wallets shall checkbox a statement of compliance to be maintained on the wallet’s GitHub account or Website. The statement may qualitatively discuss the security program and include additional elements, or simply state that it is compliant with the program outlined below. When asserting that open items will be in place within some time period of being listed, target dates shall be included and clearly defined..."

Hey @Calcifer1001 I wanted to check the status regarding this, so we can plan when the PR could be possibly merged after everything is addressed. If you can give us an updated, that would be great. Thanks!

AmmarHumackicSQA avatar Nov 04 '22 15:11 AmmarHumackicSQA

Hello. Sorry for the late response.

I'm finishing editing our homepage with the security measurements. As I recall, it was the last thing it was needed from us. Is this correct? Is there anything new we should consider?

Calcifer1001 avatar Nov 25 '22 14:11 Calcifer1001

It is deployed now. You can see it in https://narwallets.com/ at the FAQ section

Calcifer1001 avatar Nov 25 '22 15:11 Calcifer1001

  • Can you have a look at the comments which are not resolved yet?
  • There are linting issues, can you please fix them?
  • Add Narwallets in the root readme.md of the project.
  • Update angular example to include narwallets too.
  • Merge your branch with the latest changes of our dev branch and fix conflicts.
  • Injected Wallet NEP has been merged near/NEPs#408 check it out and see if Narwallets follows the NEP.

Hey @Calcifer1001 if you have any questions regarding these points let us know. Thanks!

AmmarHumackicSQA avatar Dec 05 '22 11:12 AmmarHumackicSQA

  • Can you have a look at the comments which are not resolved yet?
  • There are linting issues, can you please fix them?
  • Add Narwallets in the root readme.md of the project.
  • Update angular example to include narwallets too.
  • Merge your branch with the latest changes of our dev branch and fix conflicts.
  • Injected Wallet NEP has been merged near/NEPs#408 check it out and see if Narwallets follows the NEP.

Hey @Calcifer1001 if you have any questions regarding these points let us know. Thanks!

Regarding this, I'm having a doubt about the NEP408 (I think it would be the last thing). I've run the project, and seen the following object: image

If I'm understanding correctly, we would need to implement all those methods, and Narwallets would be NEP408 and we can be added to the wallet-selector. Is this correct?

Thanks

Calcifer1001 avatar Dec 06 '22 22:12 Calcifer1001

Hey @Calcifer1001, as @kujtimprenkuSQA mentioned, NEP-408: Injected Wallet API has been merged and as stated in the CONTRIBUTING.md file the wallet project must comply with the Wallet Product Criteria (see the second point of it) to be listed on Wallet Selector.

There is also Default Wallet List Criteria in that file where it is stated that to be included in the default wallet list, a wallet project must meet the Wallet Product Criteria, the Wallet Security Criteria, and have the audit completed.

AmmarHumackicSQA avatar Dec 07 '22 15:12 AmmarHumackicSQA

@Calcifer1001 reach out to me via email (check my profile or add me on Telegram directly @ammarhumackic) if you are not already in the wallet builder Telegram group, so I can add you there if you have any additional questions and so you can be up to date with everything. Thanks!

AmmarHumackicSQA avatar Dec 07 '22 16:12 AmmarHumackicSQA

Hello @AmmarHumackicSQA . Just commited after updating against dev. The new version of Narwallets is live with the windows object according to NEP-408

Calcifer1001 avatar Jan 13 '23 13:01 Calcifer1001

@Calcifer1001 will you be updating this PR to use the new version of the Narwallets?

For example instead of interacting with the wallet through postMessage from wallet selector, you could make use of the new API in your wallet throught the injected object on the window like: window.narwallets.signIn(params);, window.narwallets.signTransaction(params); etc.

kujtimprenkuSQA avatar Jan 17 '23 12:01 kujtimprenkuSQA

Narwallets is offering both ways. Is there an issue with this? We worked hard at first to do it without the window object since we thought it might have some issues. The window object, actually does a postMessage in the end, so we just removed one step.

Calcifer1001 avatar Jan 17 '23 14:01 Calcifer1001

The reason the PR needs to use the narwallets injected object on the window is that we need to make sure those changes align with the NEP correctly.

This is a simple POC (example) of an injected wallet: https://github.com/lewis-sqa/near-injected-wallet-poc

Hello @AmmarHumackicSQA . Just commited after updating against dev. The new version of Narwallets is live with the windows object according to NEP-408

You mention here that you have committed some changes but I am just seeing "merge commits" against dev no new changes.

kujtimprenkuSQA avatar Jan 18 '23 13:01 kujtimprenkuSQA

This is since the window object gets injected on the Narwallets repo.

Calcifer1001 avatar Jan 18 '23 17:01 Calcifer1001

Or the thing is to call window.narwallets.signAndSendTransaction when the Wallet Selector signAndSendTransaction method is called?

Calcifer1001 avatar Jan 18 '23 18:01 Calcifer1001

@Calcifer1001 can you please fix the conflicts in this PR and merge it with the latest changes of dev branch, once that is done we will then merge this PR.

About my latest comments here in this PR I think it's best if we discuss it in a more convenient way via telegram to clarify the confusion I might have created.

kujtimprenkuSQA avatar Jan 19 '23 11:01 kujtimprenkuSQA

Ok. Feel free to text me in tg. I think you already have my handle, right? I'll fix the issues and let you know

EDIT: Already fixed the conflicts

Calcifer1001 avatar Jan 19 '23 14:01 Calcifer1001

Thank you very much! May I know an estimated time for having it on main?

Calcifer1001 avatar Jan 23 '23 12:01 Calcifer1001