wallet-selector icon indicating copy to clipboard operation
wallet-selector copied to clipboard

Published 20 hours ago • verified publisher icon near

feat: Add safePalWallet support.

Open bryanForSafe opened this issue 3 years ago • 4 comments

Description

Add safePalWallet support.

Closes # (issue)

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • [ ] FIX - a PR of this type patches a bug.
  • [x] FEATURE - a PR of this type introduces a new feature.
  • [ ] BUILD - a PR of this type introduces build changes.
  • [ ] CI - a PR of this type introduces CI changes.
  • [ ] DOCS - a PR of this type introduces DOCS improvement.
  • [ ] STYLE - a PR of this type introduces style changes.
  • [ ] REFACTOR - a PR of this type introduces refactoring.
  • [ ] PERFORMANCE - a PR of this type introduces performance changes.
  • [ ] TEST - a PR of this type adds more tests.
  • [ ] CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • [ ] BREAKING CHANGE - SPECIFY: _______
  • [x] NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

bryanForSafe avatar Aug 13 '22 03:08 bryanForSafe

Hi @bryanForSafe , thanks for submitting this PR. You can find the criteria for including new wallets for Wallet Selector in our CONTRIBUTING.md file, and please confirm that the criteria are met or can be met within the required timeline.

AmmarHumackicSQA avatar Aug 16 '22 15:08 AmmarHumackicSQA

Hi @bryanForSafe , thanks for submitting this PR. You can find the criteria for including new wallets for Wallet Selector in our CONTRIBUTING.md file, and please confirm that the criteria are met or can be met within the required timeline.

OK, thank you, we'll done it.

bryanForSafe avatar Aug 19 '22 09:08 bryanForSafe

Hi @bryanForSafe when can we expect these changes to be implemented? Thanks.

AmmarHumackicSQA avatar Sep 29 '22 11:09 AmmarHumackicSQA

Hi @bryanForSafe when can we expect these changes to be implemented? Thanks.

@bryanForSafe can you provide any info on this? Thanks!

AmmarHumackicSQA avatar Oct 11 '22 13:10 AmmarHumackicSQA

@bryanForSafe Can we get your response to the changes requested?

gutsyphilip avatar Nov 08 '22 17:11 gutsyphilip

@bryanForSafe gentle bump 🙂

AmmarHumackicSQA avatar Nov 28 '22 07:11 AmmarHumackicSQA

Hey @bryanForSafe , any news on this one?

DamirSQA avatar Dec 15 '22 09:12 DamirSQA

Hey, @bryanForSafe can you let us know what is the status regarding this PR? We might need to close it soon if we don't get any response. Thanks

AmmarHumackicSQA avatar Jan 05 '23 14:01 AmmarHumackicSQA