nearcore icon indicating copy to clipboard operation
nearcore copied to clipboard

Fix num validators in neard INFO stats log summary to include chunk only producers

Open anthony-near opened this issue 3 years ago • 2 comments

Fix for issue: https://github.com/near/nearcore/issues/7780

For epoch id: 7STQ9NZ61UCw6ec4DYoWRAuhUKFjLsq6nAaZT4f3bWpy From go/mainnet-debug (screenshot below): Num Validators (126) = chunk only producing validators (26) + block producing validators (100) (which also produce chunks) In code: num_validators = chunk_validators.len() (since both chunk only and block producing validators produce chunks)

Updated to include output for the number of chunk only validators - see local node output screenshot.

Validated fix on local node (see node output screenshot).

Screen Shot 2022-10-13 at 11 12 15 AM

Screenshot from 2022-10-13 12-12-02

anthony-near avatar Oct 06 '22 21:10 anthony-near

I think we should show both numbers. Perhaps as 100+17 validators?

mina86 avatar Oct 13 '22 00:10 mina86

I must say though I’m not a fan of linking to screenshots in commit messages. I’m especially not a fan of making screenshots of plain text logs.

mina86 avatar Oct 13 '22 16:10 mina86

I believe this PR is not being actively worked on.

akhi3030 avatar Apr 20 '23 15:04 akhi3030