nearcore icon indicating copy to clipboard operation
nearcore copied to clipboard

genesis_config can be modified manually

Open markotonic opened this issue 2 years ago • 2 comments

Describe the bug genesis_config.json is generated by update_res.py. This file should not be modified by hand. However, no automated test catches a manual modification to this file. This could be fixed by running the same logic in update_res.py check.

To Reproduce Modify any field in genesis_config.json and run tests.

Expected behavior A clear and concise description of what you expected to happen.

Version (please complete the following information):

  • nearcore commit/branch: master (d159821834107f2d2b975695005ee9e7b62af0c8)
  • rust version (if local) 1.60.0
  • local

markotonic avatar May 24 '22 03:05 markotonic

However, no automated test catches a manual modification to this file.

This isn’t true. We’re running update_res.py check as part of presubmit tests.

mina86 avatar May 24 '22 05:05 mina86