nearcore icon indicating copy to clipboard operation
nearcore copied to clipboard

Add Rosetta tests to CI

Open MaksymZavershynskyi opened this issue 3 years ago • 8 comments

We need to run Rosetta test suite as part of our CI to be able to know when something gets broken.

MaksymZavershynskyi avatar Aug 17 '20 00:08 MaksymZavershynskyi

Plan

  • [ ] Configure the test suite: a. Run rosetta-cli check:construction (configure rosetta.cfg with some scenarios) b. Run rosetta-cli check:data in parallel with rosetta-cli check:construction
  • [x] Add compilation of nearcore with the rosetta_rpc feature flag enabled and include the test suite execution to our CI setup

frol avatar Aug 17 '20 21:08 frol

@frol what is the status of this issue?

bowenwang1996 avatar Jun 29 '21 03:06 bowenwang1996

This issue is still relevant, but not urgent.

frol avatar Aug 09 '21 23:08 frol

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 07 '21 23:11 stale[bot]

@mina86 I think it is probably a good first task for you in terms of Rosetta

bowenwang1996 avatar Nov 08 '21 22:11 bowenwang1996

I’m still going to be adding pytest tests but I think this can be closed.

mina86 avatar Dec 07 '21 03:12 mina86

@mina86 Well, actually, we needed to integrate the official Rosetta compliance checks: https://github.com/coinbase/rosetta-cli#checkdata (check:data and check:construction): https://github.com/near/nearcore/issues/3186#issuecomment-675124554

P.S. You may create a new issue if you want to separate the concerns

frol avatar Dec 07 '21 13:12 frol

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 07 '22 13:03 stale[bot]