nearcore
nearcore copied to clipboard
Limit keys and values in storage, limit state part size
- [x] Add a limit for max key and max value that can be stored by contracts
- [x] Figure out the maximum key and value length that can be in storage (written by any of the code, not just storage)
- [ ] Add a config value for
max_state_part_overhead
, see #1792 and #1771
@evgenykuzyakov The first two items are implemented by https://github.com/nearprotocol/nearcore/pull/1913 correct?
@Kouprin the PR does not seem to be blocked anymore. Assigning it to you, so that you can merge and close it. Also lowered the priority to P1 since the initial assignment of P0 was incorrect, I think.
@nearmax what is happened that you assigned this task on me?
This issue is waiting for https://github.com/nearprotocol/nearcore/pull/1771 to be done, since you are the person working on it I assigned it to you. Once the PR is closed this issue should be closed too.
@nearmax nope, #1771 is blocked for merging because of this issue.
@nearmax nope, #1771 is blocked for merging because of this issue.
Got it.
This is not needed before the Mainnet, since we will be able to introduce this variable into config later, together with other new variables. Moving to Ice Box
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
I believe we have all the limiters we need. Just need to investigate the upper bound for state parts.
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
Boundary for state part size is tracked in #1786.