nearcore icon indicating copy to clipboard operation
nearcore copied to clipboard

Limit keys and values in storage, limit state part size

Open mikhailOK opened this issue 5 years ago • 12 comments

  • [x] Add a limit for max key and max value that can be stored by contracts
  • [x] Figure out the maximum key and value length that can be in storage (written by any of the code, not just storage)
  • [ ] Add a config value for max_state_part_overhead, see #1792 and #1771

mikhailOK avatar Dec 02 '19 22:12 mikhailOK

@evgenykuzyakov The first two items are implemented by https://github.com/nearprotocol/nearcore/pull/1913 correct?

maxzaver avatar Jan 20 '20 01:01 maxzaver

@Kouprin the PR does not seem to be blocked anymore. Assigning it to you, so that you can merge and close it. Also lowered the priority to P1 since the initial assignment of P0 was incorrect, I think.

maxzaver avatar Feb 04 '20 19:02 maxzaver

@nearmax what is happened that you assigned this task on me?

Kouprin avatar Feb 04 '20 19:02 Kouprin

This issue is waiting for https://github.com/nearprotocol/nearcore/pull/1771 to be done, since you are the person working on it I assigned it to you. Once the PR is closed this issue should be closed too.

maxzaver avatar Feb 04 '20 21:02 maxzaver

@nearmax nope, #1771 is blocked for merging because of this issue.

Kouprin avatar Feb 04 '20 21:02 Kouprin

@nearmax nope, #1771 is blocked for merging because of this issue.

Got it.

maxzaver avatar Feb 04 '20 21:02 maxzaver

This is not needed before the Mainnet, since we will be able to introduce this variable into config later, together with other new variables. Moving to Ice Box

maxzaver avatar Mar 22 '20 23:03 maxzaver

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 01 '21 12:07 stale[bot]

I believe we have all the limiters we need. Just need to investigate the upper bound for state parts.

bowenwang1996 avatar Jul 01 '21 23:07 bowenwang1996

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 29 '21 23:09 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 29 '21 02:12 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 31 '22 04:03 stale[bot]

Boundary for state part size is tracked in #1786.

Longarithm avatar May 02 '23 15:05 Longarithm