nearcore icon indicating copy to clipboard operation
nearcore copied to clipboard

Unable to compile `core/chain-configs/src/client_config.rs`

Open staffik opened this issue 4 months ago • 1 comments

Running

cargo test --package near-chain-configs --lib --features nightly --features metrics -- genesis_validate::test::test_total_supply_not_match --exact --nocapture

on recent master (ca978411bbc8596cf3978e6e1ecad90184d6046e) resulted in compilation errors:

error[E0277]: the trait bound `time::Duration: Serialize` is not satisfied
    --> core/chain-configs/src/client_config.rs:334:17
     |
334  | #[derive(Clone, serde::Serialize)]
     |                 ^^^^^^^^^^^^^^^^ the trait `Serialize` is not implemented for `time::Duration`
...

Context:

% rustc --version
rustc 1.76.0 (07dca489a 2024-02-04)

and

Apple M2 Max
MacOS 14.2.1 (23C71)

staffik avatar Mar 06 '24 11:03 staffik

Relevant context: https://near.zulipchat.com/#narrow/stream/300659-Rust-.F0.9F.A6.80/topic/.E2.9C.94.20Unable.20to.20compile.20.60core.2Fchain-configs.2Fsrc.2Fclient_config.2E.2E.2E/near/424937326

in particular we should explore if we want to have a CI job or some other way to test for -p builds to double check that each package individually has correct feature flags.

nagisa avatar Mar 06 '24 13:03 nagisa