near-explorer icon indicating copy to clipboard operation
near-explorer copied to clipboard

@media queries should have 1px difference for min-width and max-width values

Open frol opened this issue 3 years ago • 1 comments

Story

I observed in quite a few places that @media (min-width) and @media (max-width) had the same values. It should be something like max-width: 767px and min-width: 768px (one pixel difference), etc. In validators.jsx the media min and max values are the same.

Acceptance Criteria

  • [ ] The affected widths should be manually tested and confirmed that those do not overlap and apply two sets of rules at the same time
  • [ ] Mobile ok

frol avatar May 24 '21 11:05 frol

@frol you are right. According to doc we should do like so

@media (min-width: 768px) and (max-width: 1199.98px) { ... }

And .98 ending is needed to work fine on retina screens.

shelegdmitriy avatar Jun 09 '21 11:06 shelegdmitriy