near-explorer icon indicating copy to clipboard operation
near-explorer copied to clipboard

Published 20 hours ago • verified publisher icon near

Correctly display Borsh arguments in contract calls

Open kcole16 opened this issue 5 years ago • 4 comments

See https://app.zenhub.com/workspaces/chainmiddleware-5cea2bcf78297c385cf0ec81/issues/nearprotocol/nearcore/2167

Story

As a user, I want to view the arguments of a contract call in a readable format whether they are in JSON or Borsh.

Acceptance Criteria

  • [ ] For functionCall actions, arguments are displayed in readable format in TX detail page /transaction/<txHash>

kcole16 avatar Feb 24 '20 17:02 kcole16

@vgrichina Does it make more sense to handle Borsh directly in Explorer, or to use a nearlib helper function? And do we still think hexdump is the way to go? https://www.npmjs.com/package/hexdump-nodejs

kcole16 avatar Feb 24 '20 18:02 kcole16

FYI, hexdump is already implemented since #183

frol avatar Feb 24 '20 18:02 frol

FYI, hexdump is already implemented since #183

Awesome!

In that case, what are the remaining TODOs here?

kcole16 avatar Feb 24 '20 18:02 kcole16

Well, we still don't display borsh-serialized arguments, but they are not yet properly implemented AFAIK, so there are no actionable items here right now.

frol avatar Feb 24 '20 20:02 frol