near-explorer icon indicating copy to clipboard operation
near-explorer copied to clipboard

DEC-566: Promote /beta/transactions Explorer page to non-beta

Open luixo opened this issue 1 year ago • 8 comments

luixo avatar Oct 17 '22 15:10 luixo

Bundle size diff

Type Old size New size Diff
Client 2.73 MB 2.73 MB -2 B (-0.00%)
Server 370.94 KB 370.94 KB 0 B (0.00%)

github-actions[bot] avatar Oct 17 '22 15:10 github-actions[bot]

@luixo Overall looks good but why there is no preview link?

shelegdmitriy avatar Oct 18 '22 11:10 shelegdmitriy

There is a problem on render, it doesn't deploy frontend. I have a discussion with tech support there.

luixo avatar Oct 18 '22 13:10 luixo

Does beta version of the page render well on mobile?

Also, there are quite some places where the transaction action misses quite some details, e.g. Stake action is rendering nothing useful:

image

https://explorer.near.org/beta/transactions/DpqDQri9u2monLxGu5sHztqV7vqDZvxsNuwZ1ZXtt3z2

Function call action could feature attached gas and attached deposit (well, it is missing from the current design as well)

And we have not solved the small NEAR amounts display, which might easily confuse people.

frol avatar Oct 19 '22 10:10 frol

Does beta version of the page render well on mobile?

Nope, it does not. We need this PR to preview what /beta pages look like (idk why not just use /beta prefix, but apparently PR is easier) to discuss how we can adapt it to production.

Also, there are quite some places where the transaction action misses quite some details, e.g. Stake action is rendering nothing useful

Thanks for pointing out!

luixo avatar Oct 19 '22 11:10 luixo

@luixo We never had time to sit down and actually think through each of the action details we display, and that is important to do.

frol avatar Oct 19 '22 11:10 frol

We never had time to sit down and actually think through each of the action details we display, and that is important to do.

I'll point that out to those who make decisions.

luixo avatar Oct 19 '22 12:10 luixo

@luixo please include in this PR a fix to the mobile layout. Notice how the header extends beyond the view's border. IMG_4891

For the suggested improvements targeting enhancements which are also missing from the current explorer pages, let's save those for subsequent issues/PRs.

charleslavon avatar Oct 19 '22 14:10 charleslavon