near-explorer icon indicating copy to clipboard operation
near-explorer copied to clipboard

Support a new TelemetryInfo field: 'blob'

Open nikurt opened this issue 1 year ago • 4 comments

Support a new TelemetryInfo field: 'blob', which will be stored in the DB as a string. This field will let us easily extend TelemetryInfo without modifying explorer backend or the DB schema.

nikurt avatar Jul 25 '22 16:07 nikurt

Do we plan to have any checks on what's in the field? Can malicious actor fill up our DB with 1048575 chars of junk?

luixo avatar Jul 25 '22 16:07 luixo

@nikurt I would like to avoid storing garbage. Please, consider to make telemetry messages well-defined

frol avatar Jul 25 '22 18:07 frol

@frol is your concern that a random user can set the new field to be 1M of arbitrary text, or is your concern that every field of Telemetry info needs to be well defined in advance? If the latter, that is justified by making it much easier to make changes to telemetry info. If the former, do you have suggestions how to counteract that? Is 1M length limit to high?

nikurt avatar Jul 25 '22 18:07 nikurt

@nikurt

If the latter, that is justified by making it much easier to make changes to telemetry info.

Ease of making changes can turn into a problem that clients (e.g. Explorer) cannot rely on having that information available.

As per our private discussion, I think for the experimentation phase it is the best to go with a custom telemetry server given that config.json allows to have a list of telemetry endpoints.

frol avatar Jul 26 '22 07:07 frol