near
feat: reconstruct `deploy-global-contract`
Should be merged after: https://github.com/near/near-jsonrpc-client-rs/pull/179 https://github.com/bos-cli-rs/near-socialdb-client-rs/pull/36
@PolyProgrammist Sorry, there was a typo. Fixed in https://github.com/near/near-cli-rs/pull/521/commits/bcce5b7ac48ee8ea82f82d5b56af651bcd80bcea
Could you please add tests for your feature if it's not too hard? Otherwise if it's too big - then there is an issue for that https://github.com/near/near-cli-rs/issues/62, can be done in a separate pull request later
Suddenly I don't see this comment https://github.com/near/near-cli-rs/pull/521/files#r2494022952 on this page so let it be here
Could you please add tests for your feature if it's not too hard? Otherwise if it's too big - then there is an issue for that #62, can be done in a separate pull request later
Not sure what exactly needs to be tested. Should I test that transaction reconstruction and download action download proper wasm at the certain block?
Maybe I'm missing something, but I see tests only for types, not for action logic itself. Are there any examples of this?
Could you please add tests for your feature if it's not too hard? Otherwise if it's too big - then there is an issue for that #62, can be done in a separate pull request later
Not sure what exactly needs to be tested. Should I test that transaction reconstruction and download action download proper wasm at the certain block?
Maybe I'm missing something, but I see tests only for types, not for action logic itself. Are there any examples of this?
I have added a simple example for tests in tests/ directory. Though testing reconstruct-transaction is better to do in a separate PR
@frolvanya Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!
Current status: waiting for merge
| Reviewer | Score |
|---|---|
| @PolyProgrammist | 13 |
Your contribution is much appreciated with a final score of 13! You have received 130 Sloth points for this contribution
@PolyProgrammist received 25 Sloth Points for reviewing and scoring this pull request.
What is the Race of Sloths
Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow
For contributors:
- Tag @race-of-sloths inside your pull requests
- Wait for the maintainer to review and score your pull request
- Check out your position in the Leaderboard
- Keep weekly and monthly streaks to reach higher positions
- Boast your contributions with a dynamic picture of your Profile
For maintainers:
- Score pull requests that participate in the Race of Sloths and receive a reward
- Engage contributors with fair scoring and fast responses so they keep their streaks
- Promote the Race to the point where the Race starts promoting you
- Grow the community of your contributors
Feel free to check our website for additional details!
Bot commands
- For contributors
- Include a PR:
@race-of-sloths includeto enter the Race with your PR
- Include a PR:
- For maintainers:
- Invite contributor
@race-of-sloths inviteto invite the contributor to participate in a race or include it, if it's already a runner. - Assign points:
@race-of-sloths score [1/2/3/5/8/13]to award points based on your assessment. - Reject this PR:
@race-of-sloths excludeto send this PR back to the drawing board. - Exclude repo:
@race-of-sloths pauseto stop bot activity in this repo until@race-of-sloths unpausecommand is called
- Invite contributor
🏆 Score recorded!
It looks like @PolyProgrammist provided a score of 11, but based on our Fibonacci scoring rules, we've adjusted it to 13.
[!TIP] We accept only the following Fibonacci numbers [0, 1, 2, 3, 5, 8, 13] for scoring