near-api-js icon indicating copy to clipboard operation
near-api-js copied to clipboard

Add remote RPC for backward compatibility of testing

Open denbite opened this issue 1 year ago • 3 comments

Pre-flight checklist

  • [x] I have read the Contributing Guidelines on pull requests.
  • [x] Commit messages follow the conventional commits spec
  • [ ] If this is a code change: I have written unit tests.
  • [ ] If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • [ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Although the migration to near-workspaces for testing was a great idea (#1211), it doesn't work on M1 chips as expected, causing a lot of WasmerCompileErrors

image

This Pull Request extends the testing configuration file with the previous remote RPC option available by another key remote_ci, so developers will be able to decide on their own which option to use just by adjusting NODE_ENV environment variable

Test Plan

Related issues/PRs

#1211

denbite avatar Jan 28 '24 15:01 denbite

⚠️ No Changeset found

Latest commit: 90755e7ad8c266f3be1e856243b75de1d717d8a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 28 '24 15:01 changeset-bot[bot]

That's strange, I'm using M2 Pro currently and I don't have the same issue. Will have to investigate further.

vikinatora avatar Jan 29 '24 07:01 vikinatora

it's really weird, I couldn't figure out the cause of the issue, but it keeps happening all the time, we might consider creating another PR for this

anyway, the purpose of this RP is to provide the remote CI RPC option and let developers choose

denbite avatar Jan 29 '24 17:01 denbite