core-contracts icon indicating copy to clipboard operation
core-contracts copied to clipboard

Staking pool contract is out-of-date

Open emlautarom1 opened this issue 1 year ago • 3 comments

Twinstake is building a variation on the staking-pool contract with support for whitelisting. During development, we faced some issues related to the contract dependencies being out of date which are detailed in this PR: https://github.com/twinstake/permissioned-delegation-near/pull/6.

In order to continue development, we would like to know what is the suggested upgrade path for this contract - be it either upgrade dependencies or start from scratch from a different template.

emlautarom1 avatar Jun 30 '23 19:06 emlautarom1

I wouldn't start from scratch. The contract is battle tested and used in prod. Better to upgrade or use the old dependencies.

robert-zaremba avatar Jul 06 '23 06:07 robert-zaremba

I would recommend just upgrading dependencies; it shouldn’t be too hard.

Note, don’t use Rust 1.70+ (use 1.69 or older): https://github.com/near/nearcore/issues/9143

frol avatar Jul 06 '23 06:07 frol

Unfortunately, upgrading dependencies resulted in integration tests to fail. Details about the issues are available here: https://github.com/twinstake/permissioned-delegation-near/pull/8

emlautarom1 avatar Jul 06 '23 19:07 emlautarom1