borsh-rs icon indicating copy to clipboard operation
borsh-rs copied to clipboard

feat(schema): for hashes

Open dzmitry-lahoda opened this issue 9 months ago • 1 comments

for #293

dzmitry-lahoda avatar May 15 '24 21:05 dzmitry-lahoda

does not seem any of failed CI issues relates to my code, locally cargo test was success

dzmitry-lahoda avatar May 15 '24 21:05 dzmitry-lahoda

@frol @dj8yfo may you help me?

error: unnecessary use of `get(param).is_some()`
   --> borsh-derive/src/internals/generics.rs:159:45
    |
159 |             if associated_type_params_usage.get(param).is_some() && !params_set.contains(param) {
    |                                             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(param)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
    = note: `-D clippy::unnecessary-get-then-check` implied by `-D clippy::all`
    = help: to override `-D clippy::all` add `#[allow(clippy::unnecessary_get_then_check)]`

seems something with CI as my PR has no relation to this code

dzmitry-lahoda avatar May 24 '24 09:05 dzmitry-lahoda

change is also backward compatible with S = RandomState

dzmitry-lahoda avatar May 24 '24 09:05 dzmitry-lahoda