gokibitz icon indicating copy to clipboard operation
gokibitz copied to clipboard

Invalid Date

Open neagle opened this issue 9 years ago • 5 comments

http://gokibitz.com/kifu/Q1em_88s

I see an "invalid date", despite my brilliant fix several months ago that made GoKibitz deal properly with every kind of date I'd seen thrown at it so far. Check out what the actual date is on this SGF and see if it conforms to the spec. If it doesn't, think about whether "invalid date" is the best way to deal with, umm, invalid dates. (Maybe it is.)

neagle avatar Apr 07 '15 19:04 neagle

Can you post the SGF that causes this?

levelonedev avatar May 11 '15 04:05 levelonedev

Yes! https://gokibitz.com/api/kifu/Q1em_88s/sgf?nocomments=true

neagle avatar May 11 '15 20:05 neagle

Doh! Of course. Thanks.

levelonedev avatar May 11 '15 22:05 levelonedev

That's a messed up date string. I feel like to solve this will just have to inevitably involve a complicated if else structure of parsing. Maybe just leaving it blank is better overall.

levelonedev avatar Jun 02 '15 05:06 levelonedev

As long as it doesn't conform to the spec, I'm happy either leaving it at "invalid date" or changing it to just be blank.

neagle avatar Jun 02 '15 14:06 neagle