gokibitz icon indicating copy to clipboard operation
gokibitz copied to clipboard

Bug: text in the "Game Comments" section can be lost forever

Open OlivierBlanvillain opened this issue 7 years ago • 5 comments

How to reproduce:

  1. Write some text in the "Game Comments" section
  2. Go to "next/previous" move

After that the text is lost forever, ctrl+z or going back to previous move doesn't bring the text back. It would be nice to have a handling similar to the "current move comment" where the text is more resilient.

OlivierBlanvillain avatar Jul 15 '17 22:07 OlivierBlanvillain

This is a good idea and I'm not immediately sure how too fix this. Any ideas @neagle?

levelonedev avatar Aug 28 '17 02:08 levelonedev

The "Comment" has a different behavior, which is to keep the current in progress comment when going back and forth in moves of a game. Using the same mechanism for "Game Comments" would do the trick, so you might want to look at how it's done in "Comment".

OlivierBlanvillain avatar Aug 28 '17 16:08 OlivierBlanvillain

It's hard to make them the same mechanism, as they work a little differently—the game comment interacts with SGFs themselves, whereas comments are saved and managed via a totally separate API. That said, there's probably not a technical reason we can't manage to implement the same behavior for editing game comments.

It's just fallen a little low on my list of priorities the past six months as I've been focused on opening the National Go Center here in Washington, DC. :)

neagle avatar Aug 29 '17 01:08 neagle

I lost another lengthy comment with a same issue editing a "current move comment"...

OlivierBlanvillain avatar Sep 29 '17 21:09 OlivierBlanvillain

It's definitely a genuine issue, it's just that development time is in very short supply for me right now. (I'm co-directing next year's US Go Congress! 😓 ) Any PRs are welcome!

neagle avatar Sep 29 '17 21:09 neagle