android-testify icon indicating copy to clipboard operation
android-testify copied to clipboard

203: Support NO_COLOR

Open DanielJette opened this issue 1 year ago • 2 comments

What does this change accomplish?

Resolves #203

How have you achieved it?

Add support for NO_COLOR. See https://no-color.org/ for more information.

Scope of Impact and Testing instructions

Set export NO_COLOR=true and run various testify command (ex. ./gradlew LegacySample:testifySettings) and verify that no color is used in the output.

Notice

[!WARNING] This change must keep main in a shippable state; it may be shipped without further notice.

DanielJette avatar Sep 15 '24 20:09 DanielJette

Might be useful to respect Gradle's console output mode for this as well.

@jaredh I haven't heard of Gradle's console output mode before. Do you mean this? https://docs.gradle.org/current/userguide/command_line_interface.html#sec:command_line_customizing_log_format

DanielJette avatar Sep 20 '24 12:09 DanielJette

Might be useful to respect Gradle's console output mode for this as well.

@jaredh I haven't heard of Gradle's console output mode before. Do you mean this? docs.gradle.org/current/userguide/command_line_interface.html#sec:command_line_customizing_log_format

@DanielJette Yep, thats the one. plain should have no colour.

jaredh avatar Sep 20 '24 14:09 jaredh

https://github.com/ndtp/android-testify/pull/239 is a better solution

DanielJette avatar Nov 18 '24 15:11 DanielJette