Nathaniel Phillips

Results 37 comments of Nathaniel Phillips

Thanks Hans! 1. I created an issue at https://github.com/ndphillips/FFTrees/issues/227 capturing the extracting and editing tree descriptions and applying them to data functionality that's missing tests. I believe it's super important...

@hneth I assigned this to you as the author of the functionality, can you take this on? Thanks!

Thanks glad to see you agree. Fixing this is indeed quite a challenge. The code underlying `plot.FFTrees()` is as poorly designed as the output is beautiful :) -- I'm ok...

Let me try breaking down the plot into its elements: # Elements |Number | Title | Type | Example| |:--------|:----|:-------|:-----| |G1| Level Bar| Graphic|| |G2|Icon Array| Graphic| | |G3| Tree|...

From this, I would propose creating the following functions: ## Elements The functions below plot individual plotting elements: |Function|Element| |:------|:------| |`plot_icon_label()`| L2| |`plot_level_bar()`| G1| |`plot_icon_array()`|G2| |`plot_tree()`|G3| |`plot_confusion_matrix()`|G4| |`plot_roc()`| G5| ##...

One big question I do have is whether to transition to `ggplot2` or stay in base-R. I love ggplot2. In my personal and professional work, I have completely transitioned to...

Thanks Hans. I agree that, at least to start, sticking with base-R is a reasonable option. I'm working on this in #224