react-timezone-select icon indicating copy to clipboard operation
react-timezone-select copied to clipboard

WIP: Use specific date to update DST

Open james-camilleri opened this issue 3 years ago • 1 comments

This change adds an additional optional "date" prop which can be used to set the current date. This can be used to determine whether or not DST should be applied to the listed time zones.

There's still a tiny issue that needs to be hammered out, as mentioned in the in-line comment, and tests are still missing.

james-camilleri avatar Apr 03 '22 00:04 james-camilleri

@james-camilleri hey sorry this has taken so long! What's the status of this PR? Should I check it out / add some tests potentially? Or do you still want to work on it a bit?

Thanks for your interest and contribution so far!

ndom91 avatar Jun 12 '22 17:06 ndom91

Hey, is it possible to get this merged in? I'd like to use this feature also.

BenLovell24 avatar Oct 25 '23 02:10 BenLovell24

Hey since this has gotten so out of date I'm going to close this in a few days. Feel free to comment though if you want me to keep it around if you plan on updating it, I'd still be open to accepting an addition like this :+1:

ndom91 avatar Dec 10 '23 11:12 ndom91

Closing this due to inactivity. In general though I'm not against a feature like this if anyone else wants to pick it up and open a new PR against the updated main :+1:

ndom91 avatar Dec 20 '23 12:12 ndom91