Nico Domino

Results 576 comments of Nico Domino

@nerkmind1337 this is impossible to merge, it includes a ton of unrelated changes. Please update your PR to only include the relevant changes. Might be easier to just take your...

Also regarding your issue, did I understand it correctly that username's like `Username#123` (like Discord users) get misinterpreted? I was able to reproduce the issue with the pre-existing `isDate` function...

There seem to be some merge conflicts. Otherwise it should be close. Needs another last going over, testing, etc.

> @ndom91 happy to resolve the conflict, seems to just be the pnpm-lock, so I'll try to do this tonight. Also, I have some notes from the last review in...

Haha idk, I'll check later. Notes for us for when this is merged though: - [ ] Add astro.authjs.dev domain - [ ] Add astro example repo - [ ]...

Hey looking over this and adding some minor things here and there, hope thats okay with you! We shipped a whole new docs site recently, so I reverted your `docs/*`...

Okay so I added a build step, it creates all `.js` and `.d.ts` type files into `dist/*`, including copies of all providers after copying them into here first. Also I...

Looks like we've got a `pnpm-lock.yaml` merge conflict again :joy: After you fix it, if you could pull in the updates from `main` to get all the new docs stuff,...

@wernst thanks for the PR! I haven't looked closely so can't answer your first question yet, but the docs are mostly included as typedocs in the code as comments (in...

> Hi @ndom91 , I just pushed up a commit adding the doc strings. The testing issue is also resolved. I'll let you take a look when you have a...