rattle icon indicating copy to clipboard operation
rattle copied to clipboard

Add a flag to disable curl tests?

Open dhess opened this issue 5 years ago • 3 comments

In nixpkgs, tests that hit the network aren't supported with Hydra builds, but there's currently no way in Rattle to disable just the curl tests, which means I have to disable all the Rattle tests for my CI runs.

It would be great if there were a flag to disable just the curl tests.

dhess avatar Jan 09 '20 19:01 dhess

Sounds very reasonable. Patch welcome, or I'll probably get to it in a few days.

ndmitchell avatar Jan 09 '20 19:01 ndmitchell

I’d have submitted one myself but didn’t know how you’d like it implemented. Do you have any examples of your preferred approach?

dhess avatar Jan 09 '20 19:01 dhess

No strong preferences. A flag in https://github.com/ndmitchell/rattle/blob/master/test/Test.hs#L21 seems like it might be easiest? Just skip those tests that are network using? The simple test might need splitting into two if it does both curl and non-curl stuff - I can't remember.

ndmitchell avatar Jan 09 '20 19:01 ndmitchell