hlint icon indicating copy to clipboard operation
hlint copied to clipboard

Add support for NumericUnderscores extensions from CLI/config

Open friedbrice opened this issue 3 years ago • 6 comments

Closes https://github.com/ndmitchell/hlint/issues/1434

friedbrice avatar Dec 16 '22 00:12 friedbrice

@ndmitchell Is there a different way you'd like me to approach this problem? I'm happy to rework this.

friedbrice avatar Jan 26 '23 00:01 friedbrice

Thanks, @googleson78! I'll start working on a patch.

friedbrice avatar Jan 26 '23 19:01 friedbrice

Sorry it took me so disastrously long to get to this diff - it feel off my radar. I updated the merge conflicts, but didn't test after (did it in the github UI).

I can see how this would apply to people using the API, but as far as I can tell, this won't have any impact on the command line users? Or are you expecting that this will be used through the Haskell IDE?

ndmitchell avatar Apr 02 '23 20:04 ndmitchell

@ndmitchell it works using our .hlint.yaml file. If it doesn't work for CLI uses, then that's an oversight on my part that I need to fix.

Edit to add: Here's a snippet of our .hlint.yaml, and it works as intended.

- arguments:
  - -XQuasiQuotes
  - -XTypeApplications
  - -XNumericUnderscores
  - -XNoForeignFunctionInterface
  - -XOverloadedRecordDot

friedbrice avatar Apr 19 '23 20:04 friedbrice

Sorry I let this sit for so long. Thank y'all.

friedbrice avatar Apr 20 '23 13:04 friedbrice

@ndmitchell anything we can do to get this ready to merge?

parsonsmatt avatar Oct 19 '23 15:10 parsonsmatt