hexml icon indicating copy to clipboard operation
hexml copied to clipboard

Skip over CDATA

Open mniip opened this issue 1 year ago • 1 comments

Addresses #1

  • Don't fail the parse if we run into a CDATA.
  • Do the same to CDATA as we do to comments: leave it up to the downstream user to parse them.

mniip avatar Jul 08 '24 10:07 mniip

@ndmitchell gentle prod?

mniip avatar Jul 16 '24 15:07 mniip

Thanks for the patch. I reviewed it by eye and it looks great. Can we get a test in https://github.com/ndmitchell/hexml/blob/master/src/Main.hs as well? It's pretty subtle doing this coding, and a test would give a lot of confidence.

I'm afraid I'm going to be too busy to land over the next 2 weeks, but will endeavor to do it when I'm free again after that.

ndmitchell avatar Jul 28 '24 19:07 ndmitchell

@ndmitchell ping?

mniip avatar Aug 23 '24 08:08 mniip

Thanks! I released Hexml 0.3.5 with this change.

ndmitchell avatar Aug 25 '24 17:08 ndmitchell