extra icon indicating copy to clipboard operation
extra copied to clipboard
verified publisher icon ndmitchell

Make it build with ghc-9.12

Open erikd opened this issue 1 year ago • 2 comments

ghc-9.12 has not even had a release candidate yet, nor has the ghc been forked.

I I try to built extra with current ghc@HEAD I need this.

Thanks for the pull request!

By raising this pull request you confirm you are licensing your contribution under all licenses that apply to this project (see LICENSE) and that you have no patents covering your contribution.

If you care, my PR preferences are at https://github.com/ndmitchell/neil#contributions, but they're all guidelines, and I'm not too fussy - you don't have to read them.

erikd avatar Sep 30 '24 05:09 erikd

ghc-9.12 has now been branched. The code in this PR still builds.

erikd avatar Oct 01 '24 05:10 erikd

@erikd I'm afraid it's not that straightforward, see https://github.com/ndmitchell/extra/issues/112 for discussion.

Bodigrim avatar Oct 02 '24 22:10 Bodigrim

Thanks for the PR, I've done something a bit different so that we have the same API on all versions of extra. I'll make a release of this shortly.

ndmitchell avatar Oct 19 '24 13:10 ndmitchell