Neil Mitchell

icon indicating a website link https://ndmitchell.com icon indicating an email [email protected]

icon company Meta icon location Cambridge, UK icon location Haskell/Rust programmer. All code is open source and licensed by me, not my employer. All views are my own.

Results 1206 comments of Neil Mitchell

Consider performance improvements

@j6carey yes, the copy during decoding. We omitted that in our fork.

Fix parsedField comment or code

If that''s the case, we should document it on the RawField type, and update the comment to parsedField. Might be worth adding a test though, since changing it to be...

CI test suite

Ah, I didn't spot these, and I was wondering about proto3-suite too, so figured this would be the right place to ask. But I see there are working CI tests...

Files are relative to cwd, not include files

If there is agreement that this is the right way to go, I'd be happy to submit a PR.

Files are relative to cwd, not include files

Thanks for the info, I am indeed using `parse_fromfile`. Makes sense to default to working the same way, given that is how the other library works. If I did want...

Files are relative to cwd, not include files

OK, fair enough. It's a bit of a shame that `expand_args_from` is a fairly heavyweight function, so I have to copy/paste a lot of it.

bigbro-fsatrace doesn't work on Windows

Thanks for the info - I'll test on Linux.

bigbro-fsatrace doesn't work on Windows

My only advice for Windows is just copy what fsatrace is doing, since where that didn't work I've patched it and tested it.

Add code action to suppress specific hlint warnings

HLint doesn't have a way to supress hints by line, only by definition. However, if you don't like a hint, I'd usually just ignore it for the whole module unless...

Add code action to suppress specific hlint warnings

I think having HLint have a function to find the `.hlint.yaml` file is perfectly reasonable to add to the HLint API. Writing the file is probably OK with doing it...