nnsight icon indicating copy to clipboard operation
nnsight copied to clipboard

Published 20 hours ago • verified publisher icon ndif-team

Added tokenizer_kwargs for LM init and allow user to pass custom config

Open Butanium opened this issue 10 months ago • 4 comments

Fixes #116

Butanium avatar Apr 19 '24 13:04 Butanium

@Butanium I'm worried that overloading kwargs for the tokenizer and the model means an error will be thrown when either one of them dosent have the same kwarg? Maybe there should be a tokenizer_args keyword argument?

JadenFiotto-Kaufman avatar Apr 19 '24 14:04 JadenFiotto-Kaufman

Agreed! Sorry for the delay, rn I'm crunched byt deadlines so if anyone wants to fix this issue with another PR feel free to!

Butanium avatar May 21 '24 18:05 Butanium

@JadenFiotto-Kaufman added it, let me know if I should change something

Butanium avatar May 25 '24 17:05 Butanium

This PR now also fixes https://github.com/ndif-team/nnsight/issues/115

Butanium avatar May 26 '24 12:05 Butanium

@Butanium In the future make the PR to the dev branch

JadenFiotto-Kaufman avatar May 28 '24 15:05 JadenFiotto-Kaufman

Will do, sorry !

Butanium avatar May 28 '24 15:05 Butanium