Nicholas Devenish

Results 60 comments of Nicholas Devenish

- `__str__` is probably what you mean rather than `__repr__` for the things show() is normally used as - You'd get the `AttributeError` for free by just trying to access......

So I've run my own script using the lib2to3-abstraction package [bowler](https://pybowler.io/) (https://gist.github.com/ndevenish/47813efb6f94576686495edec94cb0ac) and found: ``` With patterns: 214 All show() functions 199 As a class method 16 Don’t inherit from...

My only real problem is that it's not a generic operation. It's _extremely_ specific, based on the exact structure of the reflection table e.g. only helpful exactly after reading the...

If cctbx/dxtbx#503 is being approached differently, does this PR also need to be reworked?

I think it's relatively easy to fix, just have a custom packer (like Shoeboxes) do. It's good to have an example of it being used, it means it's worth fixing...

Some re-discussion of this issue happened in https://github.com/cctbx/dxtbx/issues/465

Ah, we fixed this issue with the downloadable release bundle, but since we're using plain python `entry_points` on the conda distribution, this has reoccured. I _believe_ the solution is the...

e.g. ``` $ pythonw $(which dials.image_viewer) $(dials.data get -q thaumatin_i04) ``` Gives: ``` DIALS (2018) Acta Cryst. D74, 85-97. https://doi.org/10.1107/S2059798317017235 The following parameters have been modified: input { experiments =...

> One consideration when choosing a library is whether it is happy with X11 forwarding. Some recent libraries require advanced OpenGL and are not compatible with `ssh -X`. Others work...

I think it did run on that job - https://dev.azure.com/azure-dials/dials/_build/results?buildId=9339&view=logs&j=728b758c-216d-5daa-c333-7c882b66b365&t=85fcb9b8-652b-5a8e-53be-fa3ac0301275 I think it's just the reporting step that something has broken, and that it doesn't run the tests if everything...