Nicolas De loof
Nicolas De loof
`docker compose run` is intended to mimic `docker run` Any reason you don't use `docker compose up --wait SERVICE` to get this feature ?
We don't consider this a legitimate addition to `run` command, as `up` already covers this usage. Ability to override command by command line argument can easily be replaced by either...
That's an interesting first step, but many questions remain with this approach Using bash array syntax was a suggestion, not sure this is the best option to be adopted for...
LGTM regarding the code approach 1. for legal reasons, you have to sign-off your commits so we can accept contributions 2. regarding compatibility break, cli/formatter applies slice formatting _per entry_,...
feel free to change "api" so that it returns `image.Summary` and you can use more of the existing public types from https://github.com/docker/cli/blob/master/cli/command/image/list.go
> maybe left from the ecs integration indeed 🥹 - lot's of legacy here, feel free to remove those (can do in a separate PR if you prefer to keep...
for JSON support, sounds way simpler to just bypass all the formater logic and rely on json.Marshall, or did I missed something ?
yes, adopt docker/cli approach with the minimal amount of code (feel free to make a few changes so you can directly use the same structs/functions) + include a dedicated if...
I'm not confident with regex and the way those are used in this context, so hardly can tell what would be the adequate expression Would you like to help us...
that's indeed a mistake writing the spec, thanks for reporting