ndeet
ndeet
As a follow up to #35 it would be nice to have helper functions to determine the total amount paid on an invoice + a isFullyPaid() function.
```[tasklist] ### Tasks - [x] Stores (Users) - [x] Stores (Rates) - [x] Stores (Rates Config) - [x] Stores (Email) - [ ] Point of Sale - [ ] Crowdfund...
We currently have conflicting class names making the need to alias them. E.g. \Client\User and \Result\User. We should follow similar pattern than Laravel and be explicit like `UserClient` and `UserResult`.
We have several places where we only return true in case of success but no false because it throws an exception in that case. As discussed with Wouter we should...
https://github.com/btcpayserver/btcpayserver-greenfield-php/blob/master/src/Client/PullPayment.php#L44 There is a description field that is missing from our client: https://docs.btcpayserver.org/API/Greenfield/v1/#operation/PullPayments_CreatePullPayment
See discussion here https://github.com/btcpayserver/btcpayserver-greenfield-php/pull/69
- make it scream on non camelCased variables (@woutersamaey comment on #41) - make it check docblocks to follow phpDocumentor syntax (but not mandatory, just formatting if there is a...
…and fails with old Currency class. Namespace was wrong as I was not aware that this repo is a clone with imports and some minor mods from the other bitpay...
@pavlenex I have tried to cover all the best practices and link to examples and not make it too long but I might have forgotten something, happy to add/remove stuff...
- Fix steps numbering; - Fix steps, add more info; - Remove duplicate img/Shopify directory and files. Related to #1352 and PR #1396 cc @pavlenex