Nick Craig-Wood

Results 1599 comments of Nick Craig-Wood

Hi @marcelowa sorry about the delay looking at this. Let's try to get it merged for 1.71 How are the integration tests looking?

> This commit removes the bypass of authentication for requests coming from Unix sockets in the rclone serve functionality. This change addresses security concerns when behind a reverse proxy, where...

Can you describe what reverse proxy you used and how you set it up please. Also what rclone service were you proxying? Thanks

Ah, OK I see what you mean now - thank you very much for the example. I didn't get that the reverse proxy was talking to `rclone serve` via unix...

@wcumsjy I updated all the urls to `.cn` ones. I don't know if it will work - please report back! [v1.70.0-beta.8597.7f715befb.fix-8257-iclouddrive-cn](https://beta.rclone.org/branch/fix-8257-iclouddrive-cn/v1.70.0-beta.8597.7f715befb.fix-8257-iclouddrive-cn/) on branch [fix-8257-iclouddrive-cn](https://github.com/rclone/rclone/tree/fix-8257-iclouddrive-cn) (uploaded in 15-30 mins)

We probably need @lostb1t to do this properly, but I thought it would be interesting to do an experiment to see if changing the URLs was enough or not. @BingoKingo...

@BingoKingo > `rclone` works fine with most files. This issue can be closed. Is that with the patched rclone with the `.cn` domain names I linked above? > It's a...

Great. I'll re-open this as we need to merge the fix (and likely do it a bit better!)

If that patch worked (I have no way of testing) then someone needs to turn it into a config option. So maybe a `region` which could be `global` or `china`...

Great investigation - thank you :-) It would be good to make this method more repeatable somehow. You could stick your bash script in a github repo with instructions in...