Nick Craig-Wood

Results 1599 comments of Nick Craig-Wood

The main task with a new backend is getting the integration tests to pass. You should be running these as soon as possible then the failures will guide you through...

This is controlled by this function https://github.com/rclone/rclone/blob/1901bae4ebcbc4cdd82f6bb1862d0479f3fa386e/fs/filter/filter.go#L551-L552 And these are the lines which need to change https://github.com/rclone/rclone/blob/1901bae4ebcbc4cdd82f6bb1862d0479f3fa386e/fs/filter/filter.go#L568-L569 That if statement needs to say something like `if f!i.Opt.FilesFromStrict && err ==...

@haruki860 that would be great :-) Let me know if you need any help. Thank you.

@shaliniganni-2000 that would be great - thanks. Let me know if you need any help.

How do we know the binary protocol is quicker? The main thing to make protocols quicker is to reduce the number of round trips, so if it does that it...

> I agree! Adding two entries never totally made sense to me. Do you want to have a go at that change? Then you can see if it fixes your...

> Here's an alternate fix -- see what you think. [6c808e6](https://github.com/rclone/rclone/commit/6c808e63fc00c6d235721e2aa6901b99cca04d90) Wow, that is quite complicated! Probably too complicated for a point release - I'm really allergic to breaking stuff...

HI @nielash I was just looking back through old pulls and came across this. There are some good fixes here - do you want go try to get them in...

> Thanks for the reviews! I will take a look -- not sure if I'll get to all of them by the 1.68 deadline, but we'll see how far I...

Is this ready for merge @nielash ? It looks that way to me but wanted to check first :-)