aqp icon indicating copy to clipboard operation
aqp copied to clipboard

Published 20 hours ago • verified publisher icon ncss-tech

Move {sp} to suggests

Open brownag opened this issue 1 year ago • 4 comments

Draft PR that removes the @sp slot from the SoilProfileCollection definition, and generally prevents loading of {sp} when {aqp} is loaded.

This breaking change is planned for aqp 2.1.x, will close #289

brownag avatar Nov 14 '23 15:11 brownag

Good idea, thanks for getting this moving. Now is a good time to break from {sp}.

dylanbeaudette avatar Nov 15 '23 07:11 dylanbeaudette

Almost ready for this. aqp 2.0.2 is on CRAN now which resolved a number of unrelated issues that I needed to clear out first.

dylanbeaudette avatar Nov 29 '23 18:11 dylanbeaudette

This is ready for review, and can be merged after CRAN release of 2.0.3

brownag avatar Apr 01 '24 22:04 brownag

It appears the "missing data" vignette build is failing due to hzdesgnname not being set for jacobs2000. Note to check/rebuild the rdas without @sp slot and make sure relevant metadata are set before merge

brownag avatar Apr 01 '24 23:04 brownag