node-geocoder icon indicating copy to clipboard operation
node-geocoder copied to clipboard

⚡️ Enhance locationiq - formattedAddress, county, unify country name

Open a-tokyo opened this issue 2 years ago • 4 comments

⚡️ Enhance locationiq geocoder:

  • add formattedAddress
  • add county
  • unify country name

closes https://github.com/nchaulet/node-geocoder/issues/336 closes https://github.com/nchaulet/node-geocoder/issues/337

a-tokyo avatar Mar 10 '22 04:03 a-tokyo

For the unify country name it is still an issue? Did you try to contact locationIQ so they can fix the problem on their side? I am not a fan of hardcoding data here, (if it's the only solution maybe but I would like us to try to see if the provider can fix their data before)

nchaulet avatar Apr 10 '22 15:04 nchaulet

@nchaulet Hey! Thanks for the response ( :

I am not a fan of hardcoding either, however, unfortunately requesting locationIQ to change their API with a breaking change is not feasible.

If you think I should remove the country name unification part, let me know. I already hardcoded the fix in my backend so this wouldn't affect my needs.

I think the other changes in this PR are crucial tho!

a-tokyo avatar Apr 10 '22 17:04 a-tokyo

Hi @A-Tokyo Yes I think it probably make sense to remove the country specificity here, otherwise great job here, as soon you removed the hardcoded country it should be good to go

nchaulet avatar Apr 14 '22 23:04 nchaulet

@nchaulet Done! 👍🏻

a-tokyo avatar Apr 15 '22 00:04 a-tokyo