ScoutSuite icon indicating copy to clipboard operation
ScoutSuite copied to clipboard

BUG: ec2-security-group-whitelists-non-elastic-ips.json

Open nunofranciscomoreira opened this issue 1 year ago • 0 comments

Describe the bug

the checks interprets IP CIDR as a boolean and check fails.

Please provide:

  • A clear and concise description of what the bug is.
    • ERROR conditions.py L46: Unable to process testcase 'inSubnets' on value '{'CIDR': '0.0.0.0/0'}', interpreted as False: unexpected type <class 'dict'> for addr arg
  • Console output using the --debug argument.
2025-01-29 12:18:55 90ccef034abd scout[25] ERROR conditions.py L46: Unable to process testcase 'inSubnets' on value '{'CIDR': '0.0.0.0/0'}', interpreted as False: unexpected type <class 'dict'> for addr arg
Traceback (most recent call last):
  File "/root/scoutsuite/lib/python3.12/site-packages/ScoutSuite/core/conditions.py", line 46, in pass_conditions
    res = pass_condition(target_obj, test_name, test_values)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/scoutsuite/lib/python3.12/site-packages/ScoutSuite/core/conditions.py", line 219, in pass_condition
    grant = netaddr.IPNetwork(b)
            ^^^^^^^^^^^^^^^^^^^^
  File "/root/scoutsuite/lib/python3.12/site-packages/netaddr/ip/__init__.py", line 1034, in __init__
    value, prefixlen = parse_ip_network(
                       ^^^^^^^^^^^^^^^^^
  File "/root/scoutsuite/lib/python3.12/site-packages/netaddr/ip/__init__.py", line 925, in parse_ip_network
    raise TypeError('unexpected type %s for addr arg' % type(addr))
TypeError: unexpected type <class 'dict'> for addr arg
  • If possible, the errors JSON file generated at the end of execution (the CLI output will provide the path to this file). The file can be sent to [email protected] to avoid including sensitive content in the GitHub issue.
    • Attached next with redacted data.

To Reproduce

Please provide:

  • The exact CLI parameters used to run Scout Suite.
    • scout aws --force --no-browser --report-name error_test --report-dir test_dir --result-format json --ruleset test_ruleset.json --debug

Additional context

test_ruleset.json

scoutsuite_errors_error_test.json

Add any other context about the problem here.

nunofranciscomoreira avatar Jan 29 '25 12:01 nunofranciscomoreira