ScoutSuite
ScoutSuite copied to clipboard
Enhancement/docker update
Description
Restructures the way docker is handled by creating a base image that just has scoutsuite, and then separate containers for each of the different cloud types. The result is much smaller images (they're still big, but reduced size by about half of what it was).
Type of change
Select the relevant option(s):
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [X] This change requires a documentation update
Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works (optional)
- [X] New and existing unit tests pass locally with my changes
Forgot to mention: this change also redoes the numbering of the image to match what version of ScoutSuite is installed. These changes are already live in the rossja/ncc-scoutsuite dockerhub repositories (still need to look at just using github container for these...)
Hi @rossja, does this PR needs any contribution or in queue to get merged ?
Codecov Report
All modified lines are covered by tests :white_check_mark:
Comparison is base (
0c90ab9
) 20.52% compared to head (f165e94
) 20.52%.
Additional details and impacted files
@@ Coverage Diff @@
## develop #1461 +/- ##
========================================
Coverage 20.52% 20.52%
========================================
Files 384 384
Lines 13038 13038
========================================
Hits 2676 2676
Misses 10362 10362
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.