jupyter-forward icon indicating copy to clipboard operation
jupyter-forward copied to clipboard

Published 20 hours ago • verified publisher icon ncar-xdev

Add `--timeout` option to the CLI

Open andersy005 opened this issue 3 years ago • 1 comments

Currently, when parsing the log file for Jupyter server information we use a while loop with a naive condition

https://github.com/ncar-xdev/jupyter-forward/blob/917c142b6b5df6b78608b1538562ec3fd5b2a907/jupyter_forward/core.py#L209-L215

This loop can easily turn into an infinite loop when something goes wrong and the log file is not found or empty. We should probably add a timeout option to the RemoteRunner class plus the CLI to allow users to configure how long we should wait before exiting the while loop.

andersy005 avatar Feb 25 '22 01:02 andersy005

Nice catch!

kmpaul avatar Feb 25 '22 03:02 kmpaul