castle icon indicating copy to clipboard operation
castle copied to clipboard

vdom classes are missing from latest HXBit git

Open deepnight opened this issue 1 year ago • 6 comments

Hi, When trying to switch to latest versions of my libs, I noticed that the vdom.* package went missing from the hxbit git repo.

What is the intended setup here? Should I stick to hxbit 1.5.0 (from 2019!) or should I find the vdom package from elsewhere?

deepnight avatar Jan 22 '24 09:01 deepnight

Old castle is no longer supported. Most of development is now made in Hide. We can eventually commit the vdom classes here if necessary. NC

Le lun. 22 janv. 2024 à 10:28, Sébastien Bénard @.***> a écrit :

Hi, When trying to switch to latest versions of my libs, I noticed that the vdom.* package went missing from the hxbit git repo.

What is the intended setup here? Should I stick to hxbit 1.5.0 (from 2019!) or should I find the vdom package from elsewhere?

— Reply to this email directly, view it on GitHub https://github.com/ncannasse/castle/issues/151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHZXQDLRTNLHYT7UCNYRD3YPYWNFAVCNFSM6AAAAABCE3V4T6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TGNBXGA3DIMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ncannasse avatar Jan 22 '24 09:01 ncannasse

I'm a bit confused then :)

Isn't this repo here to be able to import CDB data in the game and them properly typed? Or is there a new version of this importer somewhere else?

deepnight avatar Jan 22 '24 12:01 deepnight

I mean we still have the CDB part for the data model but not the editor itself so vdom is not required.

Le lun. 22 janv. 2024 à 13:14, Sébastien Bénard @.***> a écrit :

I'm a bit confused then :)

Isn't this repo here to be able to import CDB data in the game and them properly typed? Or is there a new version of this importer somewhere else?

— Reply to this email directly, view it on GitHub https://github.com/ncannasse/castle/issues/151#issuecomment-1903880382, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHZXQEASLOBBJVRXGZQLWDYPZJZ5AVCNFSM6AAAAABCE3V4T6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBTHA4DAMZYGI . You are receiving this because you commented.Message ID: @.***>

ncannasse avatar Jan 22 '24 13:01 ncannasse

Maybe we could archive the "non-lib" part to some branch and have this repo only contain the actual haxelib part?

HIDE seems stable enough to be usable for former castle users, without much change.

deepnight avatar Jan 22 '24 14:01 deepnight

Maybe I could make a PR with this repo cleanup? You will only need to add a legacy branch somewhere.

deepnight avatar Jan 24 '24 08:01 deepnight

The standalone editor is one of these hidden gems...

Personally, I dont like HIDE and always felt the old editor and its focus was/is great at what it is doing. I still use it for my projects but ran into some issues with the old official release and finally decided to fork and update the whole thing here: https://github.com/dazKind/castle

It took some fiddling with latest jquery and the hss styles also had some minor issues. (Btw, why does hss not have a haxelib release?). I also added the missing vdom classes and pointed the haxelib dependencies at the latest git-repos.

Left is old, Right is latest. image

dazKind avatar Mar 05 '24 00:03 dazKind