Deprecation warnings

[dantetekanem]

We should fix the deprecation warnings in Rails 5.

DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from block in <module:Controller> at /Users/dante/Sites/devise_openid_authenticatable/lib/devise_openid_authenticatable/controller.rb:6)
DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from <top (required)> at /Users/dante/Sites/devise_openid_authenticatable/spec/spec_helper.rb:7)
DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from <top (required)> at /Users/dante/Sites/devise_openid_authenticatable/spec/spec_helper.rb:7)
DEPRECATION WARNING: Directly inheriting from ActiveRecord::Migration is deprecated. Please specify the Rails release the migration was written for:

  class CreateTables < ActiveRecord::Migration[4.2] (called from <top (required)> at /Users/dante/Sites/devise_openid_authenticatable/spec/support/migrations.rb:4)
DEPRECATION WARNING: use_transactional_fixtures= is deprecated and will be removed from Rails 5.1 (use use_transactional_tests= instead) (called from <top (required)> at /Users/dante/Sites/devise_openid_authenticatable/spec/model_spec.rb:3)
DEPRECATION WARNING: use_transactional_fixtures= is deprecated and will be removed from Rails 5.1 (use use_transactional_tests= instead) (called from <top (required)> at /Users/dante/Sites/devise_openid_authenticatable/spec/strategy_spec.rb:3)
.DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. (called from <class:ApplicationController> at /Users/dante/Sites/devise_openid_authenticatable/spec/scenario/app/controllers/application_controller.rb:3)
...DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request methods will accept only
the following keyword arguments in future Rails versions:
params, headers, env, xhr, as

Examples:

get '/profile',
  params: { id: 1 },
  headers: { 'X-Extra-Header' => '123' },
  env: { 'action_dispatch.custom' => 'custom' },
  xhr: true,
  as: :json
 (called from block (3 levels) in <top (required)> at /Users/dante/Sites/devise_openid_authenticatable/spec/strategy_spec.rb:88)
.DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request methods will accept only
the following keyword arguments in future Rails versions:
params, headers, env, xhr, as

and in lib/devise_openid_authenticable/controller.rb:15 change !!env to !!request.env

[nbudin]

@dantetekanem: That would be fine with me, but I won't be able to do it in the near future. If you're able to work on a pull request, I'd be glad to review and merge it.

[dantetekanem]

@nbudin I've started doing it but I don't have the permissions to push a commit to the repository. Can you give me? If not I can fork the repository.

[nbudin]

@dantetekanem: I usually like to do this with forks, but for this particular repo I've actually been thinking about trying to find a new maintainer (since I don't actually use this gem myself anymore). Would you be interested in taking this over? If so I can actually just hand you the keys. :-D

[dantetekanem]

@nbudin I don't know if I'd actually have the time for this. I'll start by a fork, and in the future I can take if possible. I'll start the fork, my actual project depends on devise_openid_authenticatable and I think I should do my part also.

Thanks! I'll let you know when the commit is completed.

[dantetekanem]

@nbudin I did the cleanup, but got some real troubles with the gem rails-controller-testing, to fix it I had to move the configs inside the strategy_spec.rb. But besides that, is clean! My fork: https://github.com/dantetekanem/devise_openid_authenticatable