mapster icon indicating copy to clipboard operation
mapster copied to clipboard

5.0.1 updates

Open elastickent opened this issue 9 years ago • 12 comments

Updated version and new paths to dependencies. Also updated the readme to include 5.0.1 build and install steps.

elastickent avatar Nov 25 '16 12:11 elastickent

Please do not bundle binary files (like .zip) inside the git repository.

jvoisin avatar Nov 25 '16 17:11 jvoisin

Sure thing, thanks!

elastickent avatar Nov 26 '16 10:11 elastickent

@elastickent We're not using 5.0.1 currently, and we'd like to keep compatibility with our current used version (Kibana 2.x), and I think that this MR would break it.

What is the best practise here? A try-catch or some kind of fallback? Doing several branches/versions?

(We're not javascript super-pro, sorry :/ )

jvoisin avatar Nov 28 '16 10:11 jvoisin

Thank you for updating the screenshot, but can you please answer the question in my previous comment? Thank you.

jvoisin avatar Nov 30 '16 11:11 jvoisin

Also, maybe unrelated, in the gif you added, the refresh time is different than the timing window (10 seconds vs 1 minute). Kibana is going to fetch events from last minute and do it every 10 seconds, so you are going to see the same events many time (and more than it should). I am not sure this was clearly explained in the readme file.

xarkes avatar Dec 01 '16 16:12 xarkes

Great question. Kibana's plugin interface is not stable release to release, so separate versions seem to make the most sense to me.

Thanks for catching the timing issue in the gif.

elastickent avatar Dec 09 '16 16:12 elastickent

I don't think that we can afford to maintain several versions, especially for Kibana versions that we're not using. What about a try-catch?

jvoisin avatar Jan 09 '17 18:01 jvoisin

try catch wont work in the json file. however, what I suggest is maintaining different braches and then update the readme instruction to specify the branch version when they do the git clone

artfulhacker avatar Feb 23 '17 17:02 artfulhacker

Hi

Anyone can help me?

in package.json I changed the version for 5.4.0. I can see the mapster in visualization, I can configure, but when I try to start I receive the following message: "Visualize: Cannot read property 'group' of undefined"

Caioha avatar May 16 '17 17:05 Caioha

Same problem: Visualize: Cannot read property 'group' of undefined

Caioha avatar May 22 '17 17:05 Caioha

Visualize: Cannot read property 'group' of undefined

Disable: Place markers off grid (use geocentroid) in Coordinates and the error goes away.

purplesrl avatar Jan 21 '18 10:01 purplesrl

Can confirm that this works on 5.2.3 as I have it running in a production environment.

pbr0ck3r avatar Aug 01 '18 20:08 pbr0ck3r