Nathan Brahms

Hi @ievans Can you please post the file diff you were trying to commit, in order to aid in issue reproduction? Thanks!

I looked into this a little. It turns out that `git commit -a` does not leave diffs staged if the commit fails. (This would make sense, as `git commit` is...

I did a little more investigation with irb, and I think my conclusion is that the tree-sitter CST would need to be context-sensitive in order to represent programs consistently with...

^ way back when we talked about having a "minimum version" field in rules; semgrep would discard any rules whose minimum version was above the current version. I think ditto...

@mjambon @aryx I think the "MISSING" errors are meant to be recoverable. For example, I know tree-sitter will insert missing semi-colons on line-ends in JavaScript. IMO we shouldn't raise a...

Moving this from "bug" to "documentation". Our Semgrep contract is that we should parse all valid code, but not necessarily that we should reject invalid code. Probably worth making this...

cc. @mschwager if you still want the medium priority here?

> @nbrahms with the existence of https://github.com/returntocorp/semgrep-langs, is it now the case that a user can just edit a compiled `langs.json` file locally to edit this behavior? We should augment...

Thanks for the submission @msorens !

Note that https://semgrep.live/YD8W/ would fix the rule.