geewallet icon indicating copy to clipboard operation
geewallet copied to clipboard

Replace circle chart by hoop chart

Open webwarrior-ws opened this issue 2 years ago • 5 comments

Addresses https://github.com/nblockchain/geewallet/issues/172 (Better design for cheese chart (so that text is inside it)). Replaces #209.

webwarrior-ws avatar Oct 16 '23 10:10 webwarrior-ws

Commit that adds Maui compatibility is omitted from this PR as master doesn't have Maui support.

webwarrior-ws avatar Oct 16 '23 10:10 webwarrior-ws

Commit that adds Maui compatibility is omitted from this PR as master doesn't have Maui support.

Please add a link to that commit from here, for the record.

knocte avatar Oct 16 '23 10:10 knocte

Commit that adds Maui compatibility is omitted from this PR as master doesn't have Maui support.

Please add a link to that commit from here, for the record.

https://github.com/webwarrior-ws/geewallet/commit/552c711e8d76f15ca6ee077bfab7156d182a22ca

webwarrior-ws avatar Oct 16 '23 10:10 webwarrior-ws

LGTM! 🚀 However, I encountered a problem when attempting to install it on the Android emulator using JetBrains Rider (windows):

  Error parsing the project "Fsdk" section with GUID: "{6EE07541-91A1-42C2-A21F-2809BBDC2F50}". It is nested under "{CE79AB9D-0FB9-4606-B7C6-A78C0858CC54}" but that project is not found in the solution.

The issue was resolved by deleting certain lines from the geewallet.sln file:

	EndGlobalSection
	GlobalSection(NestedProjects) = preSolution
		{6EE07541-91A1-42C2-A21F-2809BBDC2F50} = {CE79AB9D-0FB9-4606-B7C6-A78C0858CC54}
	EndGlobalSection

Mersho avatar Feb 22 '24 11:02 Mersho

During my testing on the ubuntu 22.04 vm, I observed several issues in UI:

  • The color indicators for each currency are absent.
  • The wallet balance should be centered within the circle. Perhaps the chart could expand when an additional digit is added to the balance.
image

Mersho avatar Feb 22 '24 15:02 Mersho