geewallet
geewallet copied to clipboard
nblockchain
Frontend.Console: ask confirmation from funder
Previously we only asked the funder to press a key to continue the process. But now we ask the funder to state if he wants to continue or not.
I don't like this error "funder didn't confirm to lock the funding!". geewallet user doesn't know what funder or fundee means.
I don't like this error "funder didn't confirm to lock the funding!". geewallet user doesn't know what funder or fundee means.
Do you have any suggestions for the replacement? :thinking:
@parhamsaremi UI messages are mostly @knocte 's area
But I pinged you, so I want to know what's your best suggestion first, then I'll improve on that.
But I pinged you, so I want to know what's your best suggestion first, then I'll improve on that.
@parhamsaremi @knocte "Funding is confirmed, awaiting locking" smth like that
Channel Locking, funding_locked.
What does that mean, for the layman?
Not sure, we always call it locking, even geewallet ui says locking
Yeah I know we already have some strings that use that term, but I was never convinced about them so I'm taking this opportunity to review this. @aarani how do other wallets call this?
@parhamsaremi why is CI still red?
Yeah I know we already have some strings that use that term, but I was never convinced about them so I'm taking this opportunity to review this. @aarani how do other wallets call this?
Unfortunately idk, according to my experience with muun, they completely hide the channel making process.
Yeah I know we already have some strings that use that term, but I was never convinced about them so I'm taking this opportunity to review this. @aarani how do other wallets call this?
@parhamsaremi why is CI still red?
Sorry I was focused on other tasks I'll rebase now. Did you reach a final decision about the message?