TgSharp icon indicating copy to clipboard operation
TgSharp copied to clipboard

Discussion: Merge TgSharp.TL with TgSharp.Core

Open aarani opened this issue 3 years ago • 2 comments

Currently, we separated the TgSharp to 2 different parts namely "TgSharp.TL" and "TgSharp.Core", there is a side effect to this which is that a lot of functions/properties that should've been internal had to be public to be accessible by TgSharp.Core and caused a lot of confusion for end-users.

Only thing that should be public IMO should be the properties that user should fill or leave empty (if optional). Things like Constructors, SerializeBody and other serialize functions, DeserializeBody and other deserialize functions, Confirmed, NeedConfirmation and etc old transport properties and more so I want to propose merging these two assemblies and making all properties/methods that are not really usable by end-user internal.

P.S: using [InternalsVisibleTo] attribute is a possible solution but I don't know the implications and if it's good solution or not.

aarani avatar May 13 '21 18:05 aarani

I think IVT is a good solution.

knocte avatar May 18 '21 05:05 knocte

Ok will do this after #41 get merged cause most internal properties are removed now

aarani avatar May 18 '21 15:05 aarani