cockroachdb-laravel
cockroachdb-laravel copied to clipboard
Lumen 8 compatibility
Tested on Lumen version 7 & 8
Following error is thrown:
Declaration of Nbj\Cockroach\Grammar\Query\CockroachGrammar::compileUpdateColumns($values) must be compatible with Illuminate\Database\Query\Grammars\Grammar::compileUpdateColumns(Illuminate\Database\Query\Builder $query, array $values)
This can be fixed by changing the prototype of the method.
Confirming this issue is present.
ErrorException
Declaration of Nbj\Cockroach\Grammar\Query\CockroachGrammar::compileUpdateColumns($values) should be compatible with Illuminate\Database\Query\Grammars\Grammar::compileUpdateColumns(Illuminate\Database\Query\Builder $query, array $values)
at C:\Users\elyci\PhpstormProjects\project\vendor\nbj\cockroachdb-laravel\src\Cockroach\Grammar\Query\CockroachGrammar.php:127
123▕ *
124▕ * @param array $values
125▕ * @return string
126▕ */
➜ 127▕ protected function compileUpdateColumns($values)
128▕ {
129▕ // When gathering the columns for an update statement, we'll wrap each of the
130▕ // columns and convert it to a parameter value. Then we will concatenate a
131▕ // list of the columns that can be added into this update query clauses.
I'll see if I can open a PR for this.
This appears to be in master with 626613a - so probably could be closed?